Refactor the DataUseMeasurement class

Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

This change also has a positive side-effect that it hides
the internal details of DataUseMeasurement class from
ChromeNetworkDelegate.

BUG=640052
Committed: https://crrev.com/21318e32a681bbb2ed20f15d7e34822b723ce616
Cr-Commit-Position: refs/heads/master@{#413806}

[tbansal1, 2016-08-23 00:37:56]

Description was changed from

==========
Rename the methods in the DataUseMeasurement class

BUG=
==========

to

==========
Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

BUG=640052
==========

[tbansal1, 2016-08-23 00:41:09]

Description was changed from

==========
Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

BUG=640052
==========

to

==========
Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

This change also has a positive side-effect that it hides
the internal details of DataUseMeasurement class from 
ChromeNetworkDelegate.

BUG=640052
==========

[tbansal1, 2016-08-23 00:41:51]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-08-23 00:42:10]

tbansal@chromium.org changed reviewers:
+ sclittle@chromium.org

[tbansal1, 2016-08-23 00:42:11]

sclittle: ptal at *. Thanks.

[sclittle, 2016-08-23 00:49:28]

lgtm % nit

https://codereview.chromium.org/2269833002/diff/20001/components/data_use_mea...
File components/data_use_measurement/content/data_use_measurement.h (right):

https://codereview.chromium.org/2269833002/diff/20001/components/data_use_mea...
components/data_use_measurement/content/data_use_measurement.h:44: void
OnBeforeRedirect(net::URLRequest* request, const GURL& new_location);
nit: could you pass in |request| by const ref? Same with OnCompleted and
ReportDataUseUMA.

[tbansal1, 2016-08-23 00:57:31]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2016-08-23 00:58:50]

tbansal@chromium.org changed reviewers:
+ mmenke@chromium.org

[tbansal1, 2016-08-23 00:58:51]

mmenke: ptal at chrome_network_delegate.cc. Thanks.

https://codereview.chromium.org/2269833002/diff/20001/components/data_use_mea...
File components/data_use_measurement/content/data_use_measurement.h (right):

https://codereview.chromium.org/2269833002/diff/20001/components/data_use_mea...
components/data_use_measurement/content/data_use_measurement.h:44: void
OnBeforeRedirect(net::URLRequest* request, const GURL& new_location);
On 2016/08/23 00:49:28, sclittle wrote:
> nit: could you pass in |request| by const ref? Same with OnCompleted and
> ReportDataUseUMA.

Done.

[mmenke, 2016-08-23 15:32:51]

On 2016/08/23 00:58:51, tbansal1 wrote:
> mmenke: ptal at chrome_network_delegate.cc. Thanks.

chrome_network_delegate LGTM

[tbansal1, 2016-08-23 15:33:21]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-08-23 15:33:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2269833002/#ps60001
(title: "Also changed const* to const &")

[commit-bot: I haz the power, 2016-08-23 15:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 16:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 16:04:03]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[tbansal1, 2016-08-23 16:50:19]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 16:51:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 18:52:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 18:52:49]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tbansal1, 2016-08-23 19:01:57]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-08-23 19:01:58]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org,
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2269833002/#ps80001
(title: "More mechanical changes")

[commit-bot: I haz the power, 2016-08-23 19:02:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 19:10:21]

Description was changed from

==========
Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

This change also has a positive side-effect that it hides
the internal details of DataUseMeasurement class from 
ChromeNetworkDelegate.

BUG=640052
==========

to

==========
Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

This change also has a positive side-effect that it hides
the internal details of DataUseMeasurement class from 
ChromeNetworkDelegate.

BUG=640052
==========

[commit-bot: I haz the power, 2016-08-23 19:10:22]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-08-23 19:11:53]

Description was changed from

==========
Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

This change also has a positive side-effect that it hides
the internal details of DataUseMeasurement class from 
ChromeNetworkDelegate.

BUG=640052
==========

to

==========
Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

This change also has a positive side-effect that it hides
the internal details of DataUseMeasurement class from
ChromeNetworkDelegate.

BUG=640052

Committed: https://crrev.com/21318e32a681bbb2ed20f15d7e34822b723ce616
Cr-Commit-Position: refs/heads/master@{#413806}
==========

[commit-bot: I haz the power, 2016-08-23 19:11:54]

Patchset 3 (id:??) landed as
https://crrev.com/21318e32a681bbb2ed20f15d7e34822b723ce616
Cr-Commit-Position: refs/heads/master@{#413806}