Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: components/data_use_measurement/content/data_use_measurement.h

Issue 2269833002: Refactor the DataUseMeasurement class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More mechanical changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/content/data_use_measurement.h
diff --git a/components/data_use_measurement/content/data_use_measurement.h b/components/data_use_measurement/content/data_use_measurement.h
index cb344fa2b6a7a519301944a3013dbaae5e41104e..c115dc4bf27927ee2d8adc74b078b3d4ee0a26ba 100644
--- a/components/data_use_measurement/content/data_use_measurement.h
+++ b/components/data_use_measurement/content/data_use_measurement.h
@@ -20,6 +20,8 @@
#include "base/android/application_status_listener.h"
#endif
+class GURL;
+
namespace net {
class URLRequest;
}
@@ -38,11 +40,15 @@ class DataUseMeasurement {
const metrics::UpdateUsagePrefCallbackType& metrics_data_use_forwarder);
~DataUseMeasurement();
- // Records the data use of the |request|, thus |request| must be non-null.
- void ReportDataUseUMA(const net::URLRequest* request) const;
+ // Called right after a redirect response code was received for |request|.
+ void OnBeforeRedirect(const net::URLRequest& request,
+ const GURL& new_location);
+
+ // Indicates that |request| has been completed or failed.
+ void OnCompleted(const net::URLRequest& request, bool started);
// Returns true if the URLRequest |request| is initiated by user traffic.
- static bool IsUserInitiatedRequest(const net::URLRequest* request);
+ static bool IsUserInitiatedRequest(const net::URLRequest& request);
#if defined(OS_ANDROID)
// This function should just be used for testing purposes. A change in
@@ -80,6 +86,9 @@ class DataUseMeasurement {
base::android::ApplicationState application_state);
#endif
+ // Records the data use of the |request|, thus |request| must be non-null.
+ void ReportDataUseUMA(const net::URLRequest& request) const;
+
// A helper function used to record data use of services. It gets the size of
// exchanged message, its direction (which is upstream or downstream) and
// reports to two histogram groups. DataUse.MessageSize.ServiceName and
« no previous file with comments | « chrome/browser/precache/precache_util.cc ('k') | components/data_use_measurement/content/data_use_measurement.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698