Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2269703002: 📰 Unlaunch the NTPNoToolbar experiment (Closed)

Created:
4 years, 4 months ago by dgn
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Add a flag to disable to New Tab Page toolbar" (patchset #3 id:40001 of https://codereview.chromium.org/1806313002/ ) Reason for revert: Terminating the experiment Original issue's description: > Add a flag to disable to New Tab Page toolbar > > It is implemented using the base::Feature API. Use the command line > flag `--disable-features=NTPToolbar` to disable it. > > BUG=595362 > > Committed: https://crrev.com/dd8b63c8a415bb8e4eaad0c7bfb4dd6ae5792ed8 > Cr-Commit-Position: refs/heads/master@{#382004} BUG=595362 Committed: https://crrev.com/e523b741f5eddc65e4b4fdfe5ab287a8f41c6aaf Cr-Commit-Position: refs/heads/master@{#413521}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dgn
Created Revert of Add a flag to disable to New Tab Page toolbar
4 years, 4 months ago (2016-08-22 17:11:17 UTC) #1
Bernhard Bauer
LGTM once the trybots are green.
4 years, 4 months ago (2016-08-22 18:08:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269703002/180001
4 years, 4 months ago (2016-08-22 19:27:44 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:180001)
4 years, 4 months ago (2016-08-22 20:28:19 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 20:30:00 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e523b741f5eddc65e4b4fdfe5ab287a8f41c6aaf
Cr-Commit-Position: refs/heads/master@{#413521}

Powered by Google App Engine
This is Rietveld 408576698