Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2710)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2269703002: 📰 Unlaunch the NTPNoToolbar experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index cccf1c6ddba08bca242e5e90f876abb894347217..bda3d8c47b8f74a6ccb438cc285529b9bb94d45b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -50,6 +50,7 @@
import org.chromium.chrome.browser.ntp.cards.NewTabPageItem;
import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObserver;
import org.chromium.chrome.browser.util.MathUtils;
import org.chromium.chrome.browser.util.ViewUtils;
@@ -133,9 +134,6 @@
/** @return Whether voice search is enabled and the microphone should be shown. */
boolean isVoiceSearchEnabled();
- /** @return Whether the toolbar at the bottom of the NTP is enabled and should be shown. */
- boolean isToolbarEnabled();
-
/** @return Whether the omnibox 'Search or type URL' text should be shown. */
boolean isFakeOmniboxTextEnabledTablet();
@@ -399,7 +397,11 @@ public void onClick(View v) {
*/
private void initializeToolbar() {
NewTabPageToolbar toolbar = (NewTabPageToolbar) findViewById(R.id.ntp_toolbar);
- if (mManager.isToolbarEnabled()) {
+ if (SnippetsConfig.isEnabled()) {
+ ((ViewGroup) toolbar.getParent()).removeView(toolbar);
+ MarginLayoutParams params = (MarginLayoutParams) getWrapperView().getLayoutParams();
+ params.bottomMargin = 0;
+ } else {
toolbar.getRecentTabsButton().setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
@@ -412,10 +414,6 @@ public void onClick(View v) {
mManager.navigateToBookmarks();
}
});
- } else {
- ((ViewGroup) toolbar.getParent()).removeView(toolbar);
- MarginLayoutParams params = (MarginLayoutParams) getWrapperView().getLayoutParams();
- params.bottomMargin = 0;
}
}

Powered by Google App Engine
This is Rietveld 408576698