Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: appengine/swarming/elements/res/imp/botlist/DESIGN.md

Issue 2269643002: Extract shared filters and aliasing code (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Patch Set: Add Design.md Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/botlist/DESIGN.md
diff --git a/appengine/swarming/elements/res/imp/botlist/DESIGN.md b/appengine/swarming/elements/res/imp/botlist/DESIGN.md
new file mode 100644
index 0000000000000000000000000000000000000000..06cb123160e2f5bf5d8c256fe5c279cabf50bcb5
--- /dev/null
+++ b/appengine/swarming/elements/res/imp/botlist/DESIGN.md
@@ -0,0 +1,29 @@
+This is a highlevel overview of the pieces that make up botlist.
+
+```
+ +--------------+
+ +------------->+CommonBehavior+<-----------------+
jcgregorio 2016/08/23 17:58:59 nit: Can you add a single spacing in the boxes? Fo
kjlubick 2016/08/23 19:13:56 Done.
+ | +------+-------+ |
+ | ^ |
+ | | |
+ | | |
+ | | |
++--------+--------+ +------+--------+ +---------+----------+
+|QueryColumnFilter| |BotListBehavior| |DynamicTableBehavior|
++-----------------+ +---------------+ +--------------------+
+ ^ +-------------^ ^ ^ ^-------------------+ ^
+ | | | | | |
+ | | | +---+ | |
+ | | | | | |
+ +----+--+-----+ | +-----+------------+ +-+---+----+
+ |<bot-filters>| | |<bot-list-summary>| |<bot-list>|
jcgregorio 2016/08/23 17:58:59 This shows inheritance of behaviors, which is grea
kjlubick 2016/08/23 19:13:56 I don't think I need a diagram for this. See line
+ +-------------+ | +------------------+ +----------+
+ | +---------------+
+ +-----+<bot-list-data>|
+ +---------------+
+```
+
+Although methods defined in the various behaviors could be overwritten by each
+other, this is not done.
+
+`<bot-list>` is the main element and composes the others.
« no previous file with comments | « appengine/swarming/elements/build/js/js.js ('k') | appengine/swarming/elements/res/imp/botlist/bot-filters.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698