Delete gcl, drover, and trychange

Delete gcl, drover, and trychange

These tools are relatively standalone, and only ever worked for SVN.
Removing these is a good start to removing other SVN support code.

R=maruel@chromium.org
BUG=475321
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/92bec4f56f991d35ddcf9c4d8a0bdd8ce1b10735

[iannucci, 2016-08-24 00:53:57]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2016-08-24 00:53:57]

lgtm

https://codereview.chromium.org/2269413002/diff/1/codereview.settings
File codereview.settings (left):

https://codereview.chromium.org/2269413002/diff/1/codereview.settings#oldcode1
codereview.settings:1: # This file is used by gcl to get repository specific
information.
s/gcl/git_cl.py

https://codereview.chromium.org/2269413002/diff/1/presubmit_support.py
File presubmit_support.py (left):

https://codereview.chromium.org/2269413002/diff/1/presubmit_support.py#oldcod...
presubmit_support.py:1012: def _GetChangeLists(self):
can we make sure these raise NotImplementedError or similar?

[agable, 2016-08-24 01:10:50]

https://codereview.chromium.org/2269413002/diff/1/codereview.settings
File codereview.settings (left):

https://codereview.chromium.org/2269413002/diff/1/codereview.settings#oldcode1
codereview.settings:1: # This file is used by gcl to get repository specific
information.
On 2016/08/24 at 00:53:57, iannucci wrote:
> s/gcl/git_cl.py

Fiiiiiiiine

https://codereview.chromium.org/2269413002/diff/1/presubmit_support.py
File presubmit_support.py (left):

https://codereview.chromium.org/2269413002/diff/1/presubmit_support.py#oldcod...
presubmit_support.py:1012: def _GetChangeLists(self):
On 2016/08/24 at 00:53:57, iannucci wrote:
> can we make sure these raise NotImplementedError or similar?

They were never implemented at all on the corresponding GitChange object, and
codesearch only shows one instance of these being used which is already gated
behind a "if scm is svn".

[iannucci, 2016-08-24 01:15:11]

lgtm

[agable, 2016-08-24 16:24:06]

The CQ bit was checked by agable@chromium.org

[agable, 2016-08-24 16:24:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2269413002/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-08-24 16:24:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 16:27:35]

Description was changed from

==========
Delete gcl, drover, and trychange

These tools are relatively standalone, and only ever worked for SVN.
Removing these is a good start to removing other SVN support code.

R=maruel@chromium.org
BUG=475321
==========

to

==========
Delete gcl, drover, and trychange

These tools are relatively standalone, and only ever worked for SVN.
Removing these is a good start to removing other SVN support code.

R=maruel@chromium.org
BUG=475321

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/92bec4f56f991d...
==========

[commit-bot: I haz the power, 2016-08-24 16:27:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/92bec4f56f991d...