Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: gclient_utils.py

Issue 2269413002: Delete gcl, drover, and trychange (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gcl.py ('k') | git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index a988b824261132bca0ea9d7ff905daeacb96209b..602322b2ca8beb5e70b072c48ba7f3fa427f286f 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -1056,7 +1056,7 @@ class ExecutionQueue(object):
work_queue.ready_cond.release()
-def GetEditor(git, git_editor=None):
+def GetEditor(git_editor=None):
"""Returns the most plausible editor to use.
In order of preference:
@@ -1068,14 +1068,8 @@ def GetEditor(git, git_editor=None):
In the case of git-cl, this matches git's behaviour, except that it does not
include dumb terminal detection.
-
- In the case of gcl, this matches svn's behaviour, except that it does not
- accept a command-line flag or check the editor-cmd configuration variable.
"""
- if git:
- editor = os.environ.get('GIT_EDITOR') or git_editor
- else:
- editor = os.environ.get('SVN_EDITOR')
+ editor = os.environ.get('GIT_EDITOR') or git_editor
if not editor:
editor = os.environ.get('VISUAL')
if not editor:
@@ -1105,7 +1099,7 @@ def RunEditor(content, git, git_editor=None):
fileobj.close()
try:
- editor = GetEditor(git, git_editor=git_editor)
+ editor = GetEditor(git_editor=git_editor)
if not editor:
return None
cmd = '%s %s' % (editor, filename)
« no previous file with comments | « gcl.py ('k') | git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698