Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: media/base/pipeline_impl.cc

Issue 2269313002: Fix DCHECK when track status changes in non-playing state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a unit test for track changes in suspended state Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/renderers/renderer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_impl.cc
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc
index a4860070322080ee2b55f6c26eb926f911128db5..e4b2f36ee9016d1bf781a46b74fa885bfd8fe617 100644
--- a/media/base/pipeline_impl.cc
+++ b/media/base/pipeline_impl.cc
@@ -583,7 +583,7 @@ void PipelineImpl::RendererWrapper::OnEnabledAudioTracksChanged(
}
DCHECK(demuxer_);
- DCHECK(shared_state_.renderer);
+ DCHECK(shared_state_.renderer || (state_ != kPlaying));
base::TimeDelta currTime = (state_ == kPlaying)
? shared_state_.renderer->GetMediaTime()
@@ -602,7 +602,7 @@ void PipelineImpl::RendererWrapper::OnSelectedVideoTrackChanged(
}
DCHECK(demuxer_);
- DCHECK(shared_state_.renderer);
+ DCHECK(shared_state_.renderer || (state_ != kPlaying));
base::TimeDelta currTime = (state_ == kPlaying)
? shared_state_.renderer->GetMediaTime()
« no previous file with comments | « no previous file | media/renderers/renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698