media/renderers/renderer_impl.cc - Issue 2269313002: Fix DCHECK when track status changes in non-playing state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/renderers/renderer_impl.cc

Issue 2269313002: Fix DCHECK when track status changes in non-playing state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a unit test for track changes in suspended state Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/renderers/renderer_impl.cc

diff --git a/media/renderers/renderer_impl.cc b/media/renderers/renderer_impl.cc

index c4fbf53d3ffa3d1badacd0621677c3aaab570ade..a087603f9bab15e43cbd327b826a7631237bdc7a 100644

--- a/media/renderers/renderer_impl.cc

+++ b/media/renderers/renderer_impl.cc

@@ -229,7 +229,7 @@ void RendererImpl::RestartStreamPlayback(DemuxerStream* stream,

bool video = (stream->type() == DemuxerStream::VIDEO);

DVLOG(1) << __func__ << (video ? " video" : " audio") << " stream=" << stream

<< " enabled=" << stream->enabled() << " time=" << time.InSecondsF();

- if (state_ != STATE_PLAYING)

+ if ((state_ != STATE_PLAYING) || (audio_ended_ && video_ended_))

return;

if (stream->type() == DemuxerStream::VIDEO) {

DCHECK(video_renderer_);

« no previous file with comments | « media/base/pipeline_impl.cc ('k') | media/test/pipeline_integration_test.cc » ('j') | no next file with comments »