Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2269233002: Make pdfium recipes explicitly set GIT_MODE (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
Wei Li, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M scripts/slave/recipes/pdfium.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/pdfium.expected/android.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/drm_win_xfa.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_asan.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_no_v8.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_skia.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_no_v8.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_skia.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_no_v8.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_skia.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_rel.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
agable
4 years, 3 months ago (2016-08-23 20:35:09 UTC) #1
Wei Li
lgtm
4 years, 3 months ago (2016-08-23 21:53:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269233002/1
4 years, 3 months ago (2016-08-23 22:13:59 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-23 22:19:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/a47b3b97072ad029ae93...

Powered by Google App Engine
This is Rietveld 408576698