scripts/slave/recipes/pdfium.py - Issue 2269233002: Make pdfium recipes explicitly set GIT_MODE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/pdfium.py

Issue 2269233002: Make pdfium recipes explicitly set GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/pdfium.py

diff --git a/scripts/slave/recipes/pdfium.py b/scripts/slave/recipes/pdfium.py

index 4b5fc5f79877448c307654cf9383c3f404eb0927..cc11ae93f72dc72999fc9123f56844581f5861c7 100644

--- a/scripts/slave/recipes/pdfium.py

+++ b/scripts/slave/recipes/pdfium.py

@@ -32,7 +32,7 @@ def _CheckoutSteps(api, memory_tool, skia, xfa, v8, target_cpu, clang, gn,

assert(gn)

# Checkout pdfium and its dependencies (specified in DEPS) using gclient.

- api.gclient.set_config('pdfium')

+ api.gclient.set_config('pdfium', GIT_MODE=True)

if target_os:

api.gclient.c.target_os = {target_os}

api.bot_update.ensure_checkout(force=True)

« no previous file with comments | « no previous file | scripts/slave/recipes/pdfium.expected/android.json » ('j') | no next file with comments »