Implement reflecting on mixin applications.

Implement reflecting on mixin applications.

BUG=http://dartbug.com/12055
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26162

[Johnni Winther, 2013-08-09 06:31:01]

lgtm

https://codereview.chromium.org/22692002/diff/3001/dart/sdk/lib/_internal/lib...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/22692002/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_mirrors.dart:460: return
s('${n(mixin.qualifiedName)}(${n(superclass.qualifiedName)})');
What naming convention is this? What will the simpleName be for a named mixin
application?

https://codereview.chromium.org/22692002/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_mirrors.dart:899: // Use _superclass == this to
represent class with no superclass (Object).
Long line.

[ahe, 2013-08-09 12:17:48]

Thank you, Johnni.

A few notes to myself below.

https://codereview.chromium.org/22692002/diff/3001/dart/sdk/lib/_internal/lib...
File dart/sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/22692002/diff/3001/dart/sdk/lib/_internal/lib...
dart/sdk/lib/_internal/lib/js_mirrors.dart:460: return
s('${n(mixin.qualifiedName)}(${n(superclass.qualifiedName)})');
On 2013/08/09 06:31:01, Johnni Winther wrote:
> What naming convention is this? What will the simpleName be for a named mixin
> application?

It is this naming convention: mixin(superclass). It stems from thinking of the
mixin as a function that given a superclass returns a class (which is called a
mixin application).

However, Ryan and I discussed this as we want to make sure dart2js and the VM
produce the same, and we felt it would be best to use the source syntax, so this
needs to be changed.

https://codereview.chromium.org/22692002/diff/3001/dart/tests/lib/mirrors/mix...
File dart/tests/lib/mirrors/mixin_test.dart (right):

https://codereview.chromium.org/22692002/diff/3001/dart/tests/lib/mirrors/mix...
dart/tests/lib/mirrors/mixin_test.dart:7: @MirrorsUsed(targets:
'test.mixin_test, test.model, Object', override: '*')
I have discovered this test doesn't work without a MirrorsUsed annotation, and I
need to find out why.

https://codereview.chromium.org/22692002/diff/3001/dart/tests/lib/mirrors/mix...
dart/tests/lib/mirrors/mixin_test.dart:66: '{Mixin: Method(s(Mixin) in s(Mixin),
constructor),'
This is wrong, members should not include constructors.

https://codereview.chromium.org/22692002/diff/3001/dart/tests/lib/mirrors/mix...
dart/tests/lib/mirrors/mixin_test.dart:121: // TODO(ahe): The owner should
probably be the mixin application.
Actually, the mixin is the owner of members, but not the constructor (which is
explicitly copied down per the specification).

[ahe, 2013-08-14 22:10:05]

Submitting and will follow up to address my own notes. I've also filed
http://dartbug.com/12464 to be sure I don't forget.

[ahe, 2013-08-14 22:10:43]

Committed patchset #3 manually as r26162 (presubmit successful).