dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart - Issue 22692002: Implement reflecting on mixin applications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

Issue 22692002: Implement reflecting on mixin applications. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Minor bug fixes during testing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

index 2809dd7c663798568100e9ca69ad4cb98c3c1c7c..64d0cda0eb152d7fc5f53141909313fa347f9f78 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

@@ -64,7 +64,9 @@ class CodeEmitterNoEvalTask extends CodeEmitterTask {

bool needsCheckedSetter) {

fields.add(name);

});

- String constructorName = namer.safeName(classElement.name.slowToString());

+ String constructorName =

+ // TODO(ahe): Shouldn't this just be 'namer.getName(classElement)'?

+ namer.safeName(classElement.name.slowToString().replaceAll('+', '_'));

if (classElement.isNative()) {

builder.addProperty('', buildUnusedConstructor(constructorName));

} else {