Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2269163002: Remove DumpWithoutCrashing in RouteGestureEvent. (Closed)

Created:
4 years, 4 months ago by wjmaclean
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Remove DumpWithoutCrashing in RouteGestureEvent. This DumpWithoutCrashing is not providing useful diagnostics, and is generating a lot of noise in the crash reports. We are removing it and pursuing other avenues for debugging. BUG=595422 TBR=creis@chromium.org Review-Url: https://codereview.chromium.org/2207993002 Cr-Commit-Position: refs/heads/master@{#409525} (cherry picked from commit 87022427432ab8ab1d11a4d6e1143bdfeb9c12ee) Committed: https://chromium.googlesource.com/chromium/src/+/9eacdd09d64bd8555abc26e3f809a453621c3653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
wjmaclean
Committed patchset #1 (id:1) manually as 9eacdd09d64bd8555abc26e3f809a453621c3653.
4 years, 4 months ago (2016-08-23 18:23:44 UTC) #2
Charlie Reis
4 years, 4 months ago (2016-08-23 18:39:52 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698