Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2207993002: Remove DumpWithoutCrashing in RouteGestureEvent. (Closed)

Created:
4 years, 4 months ago by wjmaclean
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, jam, darin-cc_chromium.org, tdresser
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DumpWithoutCrashing in RouteGestureEvent. This DumpWithoutCrashing is not providing useful diagnostics, and is generating a lot of noise in the crash reports. We are removing it and pursuing other avenues for debugging. BUG=595422 TBR=creis@chromium.org Committed: https://crrev.com/87022427432ab8ab1d11a4d6e1143bdfeb9c12ee Cr-Commit-Position: refs/heads/master@{#409525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
wjmaclean
4 years, 4 months ago (2016-08-03 16:16:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207993002/1
4 years, 4 months ago (2016-08-03 16:16:52 UTC) #9
wjmaclean
On 2016/08/03 16:16:20, wjmaclean wrote: lgtm, thanks Oshima!
4 years, 4 months ago (2016-08-03 16:19:12 UTC) #10
wjmaclean
On 2016/08/03 16:19:12, wjmaclean wrote: > On 2016/08/03 16:16:20, wjmaclean wrote: > > lgtm, thanks ...
4 years, 4 months ago (2016-08-03 16:19:35 UTC) #11
wjmaclean
On 2016/08/03 16:19:12, wjmaclean wrote: > On 2016/08/03 16:16:20, wjmaclean wrote: > > lgtm, thanks ...
4 years, 4 months ago (2016-08-03 16:19:36 UTC) #12
Charlie Reis
LGTM
4 years, 4 months ago (2016-08-03 16:21:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 16:22:16 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 16:23:33 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87022427432ab8ab1d11a4d6e1143bdfeb9c12ee
Cr-Commit-Position: refs/heads/master@{#409525}

Powered by Google App Engine
This is Rietveld 408576698