|
|
DescriptionAdd a -keep for all Parcelables in hopes it fixes crash in the wild
BUG=639823
Committed: https://crrev.com/b66c6d1ee2b9c1c4ec687c9ded1006a167fc31c5
Cr-Commit-Position: refs/heads/master@{#414250}
Patch Set 1 #
Total comments: 2
Patch Set 2 : added crbug #Messages
Total messages: 17 (9 generated)
agrieve@chromium.org changed reviewers: + nyquist@chromium.org
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2269143005/diff/1/base/android/base_proguard_... File base/android/base_proguard_config.flags (right): https://codereview.chromium.org/2269143005/diff/1/base/android/base_proguard_... base/android/base_proguard_config.flags:51: # .aars are used. Nit: Is there a bug for this?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2269143005/diff/1/base/android/base_proguard_... File base/android/base_proguard_config.flags (right): https://codereview.chromium.org/2269143005/diff/1/base/android/base_proguard_... base/android/base_proguard_config.flags:51: # .aars are used. On 2016/08/24 21:16:12, nyquist wrote: > Nit: Is there a bug for this? Good call. Added.
The CQ bit was checked by agrieve@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org Link to the patchset: https://codereview.chromium.org/2269143005/#ps20001 (title: "added crbug")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add a -keep for all Parcelables in hopes it fixes crash in the wild BUG=639823 ========== to ========== Add a -keep for all Parcelables in hopes it fixes crash in the wild BUG=639823 Committed: https://crrev.com/b66c6d1ee2b9c1c4ec687c9ded1006a167fc31c5 Cr-Commit-Position: refs/heads/master@{#414250} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b66c6d1ee2b9c1c4ec687c9ded1006a167fc31c5 Cr-Commit-Position: refs/heads/master@{#414250}
Message was sent while issue was closed.
bauerb@chromium.org changed reviewers: + bauerb@chromium.org
Message was sent while issue was closed.
Sorry, didn't see this yesterday. I'm not completely sure if this is necessary after Toby's https://codereview.chromium.org/2269553003, but if we are going to revisit this anyway per the linked bug, we can see if we can remove it then.
Message was sent while issue was closed.
On 2016/08/25 11:38:24, Bernhard Bauer wrote: > Sorry, didn't see this yesterday. I'm not completely sure if this is necessary > after Toby's https://codereview.chromium.org/2269553003, but if we are going to > revisit this anyway per the linked bug, we can see if we can remove it then. I think the -keep is still needed, per the comment about reflected Parcelables. My CL only dealt with the obfuscation problem. |