Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2269143005: Add a -keep for all Parcelables in hopes it fixes crash in the wild (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
Bernhard Bauer, nyquist
CC:
chromium-reviews, Marc Treib, Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a -keep for all Parcelables in hopes it fixes crash in the wild BUG=639823 Committed: https://crrev.com/b66c6d1ee2b9c1c4ec687c9ded1006a167fc31c5 Cr-Commit-Position: refs/heads/master@{#414250}

Patch Set 1 #

Total comments: 2

Patch Set 2 : added crbug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M base/android/base_proguard_config.flags View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
agrieve
4 years, 3 months ago (2016-08-24 18:25:26 UTC) #2
nyquist
lgtm https://codereview.chromium.org/2269143005/diff/1/base/android/base_proguard_config.flags File base/android/base_proguard_config.flags (right): https://codereview.chromium.org/2269143005/diff/1/base/android/base_proguard_config.flags#newcode51 base/android/base_proguard_config.flags:51: # .aars are used. Nit: Is there a ...
4 years, 3 months ago (2016-08-24 21:16:13 UTC) #5
agrieve
https://codereview.chromium.org/2269143005/diff/1/base/android/base_proguard_config.flags File base/android/base_proguard_config.flags (right): https://codereview.chromium.org/2269143005/diff/1/base/android/base_proguard_config.flags#newcode51 base/android/base_proguard_config.flags:51: # .aars are used. On 2016/08/24 21:16:12, nyquist wrote: ...
4 years, 3 months ago (2016-08-25 01:00:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269143005/20001
4 years, 3 months ago (2016-08-25 01:02:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 02:10:59 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b66c6d1ee2b9c1c4ec687c9ded1006a167fc31c5 Cr-Commit-Position: refs/heads/master@{#414250}
4 years, 3 months ago (2016-08-25 02:12:54 UTC) #14
Bernhard Bauer
Sorry, didn't see this yesterday. I'm not completely sure if this is necessary after Toby's ...
4 years, 3 months ago (2016-08-25 11:38:24 UTC) #16
Tobias Sargeant
4 years, 3 months ago (2016-08-25 12:11:39 UTC) #17
Message was sent while issue was closed.
On 2016/08/25 11:38:24, Bernhard Bauer wrote:
> Sorry, didn't see this yesterday. I'm not completely sure if this is necessary
> after Toby's https://codereview.chromium.org/2269553003, but if we are going
to
> revisit this anyway per the linked bug, we can see if we can remove it then.

I think the -keep is still needed, per the comment about reflected Parcelables.
My
CL only dealt with the obfuscation problem.

Powered by Google App Engine
This is Rietveld 408576698