Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2269553003: Don't allow proguard to rename Parcelables at all. (Closed)

Created:
4 years, 4 months ago by Tobias Sargeant
Modified:
4 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, smaier
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow proguard to rename Parcelables at all. GMSCore uses Parcelables for IPCs, and so we can't safely rename anything. BUG=639722 Committed: https://crrev.com/b4ccfcdd02d5edb4849aca342b477a2beed486ff Cr-Commit-Position: refs/heads/master@{#413432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/android/base_proguard_config.flags View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Tobias Sargeant
4 years, 4 months ago (2016-08-22 10:16:33 UTC) #2
Torne
lgtm
4 years, 4 months ago (2016-08-22 11:46:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269553003/1
4 years, 4 months ago (2016-08-22 12:20:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 12:24:16 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 12:25:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4ccfcdd02d5edb4849aca342b477a2beed486ff
Cr-Commit-Position: refs/heads/master@{#413432}

Powered by Google App Engine
This is Rietveld 408576698