Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2269143002: Detect duplicate USB device notifications from udev. (Closed)

Created:
4 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Detect duplicate USB device notifications from udev. This patch adds a check to detect when udev has sent Chrome multiple notifications for the same device, ignoring the duplicates, as this behavior has been observed in the wild. I also fix DeviceReady() to not send a device added notification if a device was disconnected while it was being enumerated. The device would not have been added to the global device list in this case. BUG=638298 Review-Url: https://codereview.chromium.org/2261783002 Cr-Commit-Position: refs/heads/master@{#413273} (cherry picked from commit f2c7b56f4a4f2c16b2f7062f60ad3041217e9f20) Committed: https://chromium.googlesource.com/chromium/src/+/b69683e7f0dc6fcb3d06db36d4ada51fe56c3c18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M device/usb/usb_service_linux.cc View 2 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
4 years, 4 months ago (2016-08-23 17:34:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b69683e7f0dc6fcb3d06db36d4ada51fe56c3c18.

Powered by Google App Engine
This is Rietveld 408576698