Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2261783002: Detect duplicate USB device notifications from udev. (Closed)

Created:
4 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
juncai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Detect duplicate USB device notifications from udev. This patch adds a check to detect when udev has sent Chrome multiple notifications for the same device, ignoring the duplicates, as this behavior has been observed in the wild. I also fix DeviceReady() to not send a device added notification if a device was disconnected while it was being enumerated. The device would not have been added to the global device list in this case. BUG=638298 Committed: https://crrev.com/f2c7b56f4a4f2c16b2f7062f60ad3041217e9f20 Cr-Commit-Position: refs/heads/master@{#413273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M device/usb/usb_service_linux.cc View 2 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 4 months ago (2016-08-19 21:17:46 UTC) #2
juncai
LGTM.
4 years, 4 months ago (2016-08-19 21:51:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261783002/1
4 years, 4 months ago (2016-08-19 21:56:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 22:52:20 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 22:54:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2c7b56f4a4f2c16b2f7062f60ad3041217e9f20
Cr-Commit-Position: refs/heads/master@{#413273}

Powered by Google App Engine
This is Rietveld 408576698