third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html - Issue 2268923003: Clean up textTrackDisplayElement utility function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html

Issue 2268923003: Clean up textTrackDisplayElement utility function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html b/third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html

index 0b9d32d83014e2aabf7b2c59bdc3165960df3bae..0bde8e03071569c1a8da32052594d820d7c31ffe 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html

@@ -18,7 +18,7 @@ async_test(function(t) {

video.src = findMediaFile("video", "../content/test");

video.oncanplaythrough = t.step_func_done(function() {

- var cueDisplayElement = textTrackDisplayElement(video, "display", 0);

+ var cueDisplayElement = textTrackDisplayElement(video);

document.body.offsetTop; // Force layout.

assert_true(cueDisplayElement.offsetTop > (video.videoHeight * 0.75));

});