Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2268673002: [api] Improve documentation for SetNamedPropertyHandler(). (Closed)

Created:
4 years, 4 months ago by Franzi
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Improve documentation for SetNamedPropertyHandler(). BUG=v8:5260 Committed: https://crrev.com/3a0a24dcf36cb9c8084d9c69a6847c8cf50c161a Cr-Commit-Position: refs/heads/master@{#38823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M include/v8.h View 1 chunk +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Franzi
Hi Jochen, I found that paragraph confusing. Is this better? Thanks, Franzi
4 years, 4 months ago (2016-08-22 19:25:55 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-23 12:50:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268673002/1
4 years, 4 months ago (2016-08-23 12:53:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 13:28:28 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 13:29:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a0a24dcf36cb9c8084d9c69a6847c8cf50c161a
Cr-Commit-Position: refs/heads/master@{#38823}

Powered by Google App Engine
This is Rietveld 408576698