Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: include/v8.h

Issue 2268673002: [api] Improve documentation for SetNamedPropertyHandler(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index c93ee238585f5a86527532eb6e927ac7906a9ccb..0e8b26e3f4cbcf495122ef2a76704fd0c2b624f5 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4762,8 +4762,10 @@ class V8_EXPORT ObjectTemplate : public Template {
* from this object template, the provided callback is invoked instead of
* accessing the property directly on the JavaScript object.
*
- * Note that new code should use the second version that can intercept
- * symbol-named properties as well as string-named properties.
+ * SetNamedPropertyHandler() is different from SetHandler(), in
+ * that the latter can intercept symbol-named properties as well as
+ * string-named properties when called with a
+ * NamedPropertyHandlerConfiguration. New code should use SetHandler().
*
* \param getter The callback to invoke when getting a property.
* \param setter The callback to invoke when setting a property.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698