Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 2268633002: Remove --intl-extra flag (Closed)

Created:
4 years, 4 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
adamk, caitp
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --intl-extra flag This flag has been flipped off since 52, so it is due for removal. R=adamk@chromium.org,caitp@igalia.com BUG=v8:3785 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Committed: https://crrev.com/915ca181ccee8538531397e5c723d598aa5efadb Cr-Commit-Position: refs/heads/master@{#39435}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : Skip big object test in one configuration which is timing out #

Patch Set 4 : Remove i18n-extra #

Patch Set 5 : Fix bootstrapper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -520 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 6 chunks +0 lines, -13 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M src/js/i18n.js View 1 2 3 9 chunks +0 lines, -42 lines 0 comments Download
D src/js/intl-extra.js View 1 chunk +0 lines, -22 lines 0 comments Download
M src/js/prologue.js View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M src/v8.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D test/intl/date-format/parse-MMMdy.js View 1 chunk +0 lines, -59 lines 0 comments Download
D test/intl/date-format/parse-invalid-input.js View 1 chunk +0 lines, -37 lines 0 comments Download
D test/intl/date-format/parse-mdy.js View 1 chunk +0 lines, -53 lines 0 comments Download
D test/intl/date-format/parse-mdyhms.js View 1 chunk +0 lines, -65 lines 0 comments Download
D test/intl/extra-flag.js View 1 chunk +0 lines, -23 lines 0 comments Download
D test/intl/no-extra-flag.js View 1 chunk +0 lines, -23 lines 0 comments Download
D test/intl/number-format/parse-currency.js View 1 chunk +0 lines, -35 lines 0 comments Download
D test/intl/number-format/parse-decimal.js View 1 chunk +0 lines, -52 lines 0 comments Download
D test/intl/number-format/parse-invalid-input.js View 1 chunk +0 lines, -40 lines 0 comments Download
D test/intl/number-format/parse-percent.js View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 46 (38 generated)
Dan Ehrenberg
4 years, 4 months ago (2016-08-22 17:46:05 UTC) #16
adamk
lgtm
4 years, 4 months ago (2016-08-22 18:03:13 UTC) #17
adamk
Hmm, looks to me like this was shipped in 52, not 51. Update CL description?
4 years, 4 months ago (2016-08-22 18:08:45 UTC) #18
Dan Ehrenberg
Not sure why, but this seems to break the i18n build (which is doing fine ...
4 years, 4 months ago (2016-08-22 18:49:50 UTC) #25
adamk
Just curious if this ever got figured out?
4 years, 3 months ago (2016-09-01 20:13:54 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268633002/80001
4 years, 3 months ago (2016-09-15 02:52:40 UTC) #43
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-15 02:55:22 UTC) #44
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 02:55:45 UTC) #46
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/915ca181ccee8538531397e5c723d598aa5efadb
Cr-Commit-Position: refs/heads/master@{#39435}

Powered by Google App Engine
This is Rietveld 408576698