Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: src/js/i18n.js

Issue 2268633002: Remove --intl-extra flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix bootstrapper Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/js/intl-extra.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/i18n.js
diff --git a/src/js/i18n.js b/src/js/i18n.js
index 7ccefef928e6990f44396a849d0137938728eda8..1b53d2d55afaa835bd8dc7b9f67f544f7fedc78f 100644
--- a/src/js/i18n.js
+++ b/src/js/i18n.js
@@ -19,7 +19,6 @@
var ArrayJoin;
var ArrayPush;
-var FLAG_intl_extra;
var GlobalDate = global.Date;
var GlobalNumber = global.Number;
var GlobalRegExp = global.RegExp;
@@ -50,10 +49,6 @@ utils.Import(function(from) {
StringSubstring = from.StringSubstring;
});
-utils.ImportFromExperimental(function(from) {
- FLAG_intl_extra = from.FLAG_intl_extra;
-});
-
// Utilities for definitions
function InstallFunction(object, name, func) {
@@ -1036,9 +1031,6 @@ function initializeCollator(collator, locales, options) {
// Writable, configurable and enumerable are set to false by default.
%MarkAsInitializedIntlObjectOfType(collator, 'collator', internalCollator);
collator[resolvedSymbol] = resolved;
- if (FLAG_intl_extra) {
- %object_define_property(collator, 'resolved', resolvedAccessor);
- }
return collator;
}
@@ -1280,10 +1272,6 @@ function initializeNumberFormat(numberFormat, locales, options) {
%MarkAsInitializedIntlObjectOfType(numberFormat, 'numberformat', formatter);
numberFormat[resolvedSymbol] = resolved;
- if (FLAG_intl_extra) {
- %object_define_property(resolved, 'pattern', patternAccessor);
- %object_define_property(numberFormat, 'resolved', resolvedAccessor);
- }
return numberFormat;
}
@@ -1386,14 +1374,6 @@ function formatNumber(formatter, value) {
}
-/**
- * Returns a Number that represents string value that was passed in.
- */
-function IntlParseNumber(formatter, value) {
- return %InternalNumberParse(%GetImplFromInitializedIntlObject(formatter),
- TO_STRING(value));
-}
-
AddBoundMethod(Intl.NumberFormat, 'format', formatNumber, 1, 'numberformat');
/**
@@ -1674,10 +1654,6 @@ function initializeDateTimeFormat(dateFormat, locales, options) {
%MarkAsInitializedIntlObjectOfType(dateFormat, 'dateformat', formatter);
dateFormat[resolvedSymbol] = resolved;
- if (FLAG_intl_extra) {
- %object_define_property(resolved, 'pattern', patternAccessor);
- %object_define_property(dateFormat, 'resolved', resolvedAccessor);
- }
return dateFormat;
}
@@ -1819,18 +1795,6 @@ function FormatDateToParts(dateValue) {
%FunctionSetLength(FormatDateToParts, 0);
-/**
- * Returns a Date object representing the result of calling ToString(value)
- * according to the effective locale and the formatting options of this
- * DateTimeFormat.
- * Returns undefined if date string cannot be parsed.
- */
-function IntlParseDate(formatter, value) {
- return %InternalDateParse(%GetImplFromInitializedIntlObject(formatter),
- TO_STRING(value));
-}
-
-
// 0 because date is optional argument.
AddBoundMethod(Intl.DateTimeFormat, 'format', formatDate, 0, 'dateformat');
@@ -1910,9 +1874,6 @@ function initializeBreakIterator(iterator, locales, options) {
%MarkAsInitializedIntlObjectOfType(iterator, 'breakiterator',
internalIterator);
iterator[resolvedSymbol] = resolved;
- if (FLAG_intl_extra) {
- %object_define_property(iterator, 'resolved', resolvedAccessor);
- }
return iterator;
}
@@ -2316,10 +2277,7 @@ OverrideFunction(GlobalDate.prototype, 'toLocaleTimeString', function() {
%FunctionRemovePrototype(FormatDateToParts);
utils.Export(function(to) {
- to.AddBoundMethod = AddBoundMethod;
to.FormatDateToParts = FormatDateToParts;
- to.IntlParseDate = IntlParseDate;
- to.IntlParseNumber = IntlParseNumber;
});
})
« no previous file with comments | « src/flag-definitions.h ('k') | src/js/intl-extra.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698