Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2268553002: Small improvements to JNI references. (Closed)

Created:
4 years, 4 months ago by Torne
Modified:
4 years, 3 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small improvements to JNI references. Add a move constructor and move assignment operator to local, global and weak references to reduce reference churn (saves a small number of bytes). Allow weak references to be constructed from JavaRef. Replace NULL with nullptr in jni_weak_ref code. BUG= Committed: https://crrev.com/c6bc15dbab488636bb2f2ddff615ffacfc50c5a8 Cr-Commit-Position: refs/heads/master@{#414444}

Patch Set 1 #

Patch Set 2 : Learn about, and then fix, the most vexing parse. :) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M base/android/jni_weak_ref.h View 1 chunk +5 lines, -1 line 0 comments Download
M base/android/jni_weak_ref.cc View 4 chunks +23 lines, -7 lines 0 comments Download
M base/android/scoped_java_ref.h View 6 chunks +16 lines, -0 lines 0 comments Download
M base/android/scoped_java_ref_unittest.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Torne
4 years, 4 months ago (2016-08-22 12:44:05 UTC) #2
rmcilroy
lgtm
4 years, 4 months ago (2016-08-22 15:14:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268553002/1
4 years, 4 months ago (2016-08-22 15:19:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/116283)
4 years, 4 months ago (2016-08-22 16:14:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268553002/20001
4 years, 3 months ago (2016-08-25 14:37:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 15:43:15 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 15:44:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c6bc15dbab488636bb2f2ddff615ffacfc50c5a8
Cr-Commit-Position: refs/heads/master@{#414444}

Powered by Google App Engine
This is Rietveld 408576698