Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: base/android/scoped_java_ref_unittest.cc

Issue 2268553002: Small improvements to JNI references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Learn about, and then fix, the most vexing parse. :) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/scoped_java_ref.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/scoped_java_ref.h" 5 #include "base/android/scoped_java_ref.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 EXPECT_EQ(1, g_local_refs); 99 EXPECT_EQ(1, g_local_refs);
100 EXPECT_EQ(2, g_global_refs); 100 EXPECT_EQ(2, g_global_refs);
101 101
102 ScopedJavaLocalRef<jstring> str2(env, str.Release()); 102 ScopedJavaLocalRef<jstring> str2(env, str.Release());
103 EXPECT_EQ(1, g_local_refs); 103 EXPECT_EQ(1, g_local_refs);
104 { 104 {
105 ScopedJavaLocalRef<jstring> str3(str2); 105 ScopedJavaLocalRef<jstring> str3(str2);
106 EXPECT_EQ(2, g_local_refs); 106 EXPECT_EQ(2, g_local_refs);
107 } 107 }
108 EXPECT_EQ(1, g_local_refs); 108 EXPECT_EQ(1, g_local_refs);
109 {
110 ScopedJavaLocalRef<jstring> str4((ScopedJavaLocalRef<jstring>(str2)));
111 EXPECT_EQ(2, g_local_refs);
112 }
113 EXPECT_EQ(1, g_local_refs);
114 {
115 ScopedJavaLocalRef<jstring> str5;
116 str5 = ScopedJavaLocalRef<jstring>(str2);
117 EXPECT_EQ(2, g_local_refs);
118 }
119 EXPECT_EQ(1, g_local_refs);
109 str2.Reset(); 120 str2.Reset();
110 EXPECT_EQ(0, g_local_refs); 121 EXPECT_EQ(0, g_local_refs);
111 global_str.Reset(); 122 global_str.Reset();
112 EXPECT_EQ(1, g_global_refs); 123 EXPECT_EQ(1, g_global_refs);
113 ScopedJavaGlobalRef<jobject> global_obj2(global_obj); 124 ScopedJavaGlobalRef<jobject> global_obj2(global_obj);
114 EXPECT_EQ(2, g_global_refs); 125 EXPECT_EQ(2, g_global_refs);
115 } 126 }
116 127
117 EXPECT_EQ(0, g_local_refs); 128 EXPECT_EQ(0, g_local_refs);
118 EXPECT_EQ(0, g_global_refs); 129 EXPECT_EQ(0, g_global_refs);
119 } 130 }
120 131
121 } // namespace android 132 } // namespace android
122 } // namespace base 133 } // namespace base
OLDNEW
« no previous file with comments | « base/android/scoped_java_ref.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698