Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2268543003: Annotee: Shorten logdog log link label (Closed)

Created:
4 years, 4 months ago by Ryan Tseng
Modified:
4 years, 4 months ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Annotee: Shorten logdog log link label This changes steps/setup_build/0/logs/run_recipe/0 to run_recipe BUG=623371 Committed: https://github.com/luci/luci-go/commit/86950b2d9531c15386f2e5ccfc2a1a8aa1235464

Patch Set 1 #

Patch Set 2 : Retrain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -41 lines) Patch
M logdog/client/annotee/annotation/annotation.go View 2 chunks +3 lines, -2 lines 0 comments Download
M logdog/client/annotee/annotation/test_expectations/coverage_steps.proto.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-canceled.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-exception.html View 3 chunks +3 lines, -3 lines 0 comments Download
M milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-hang.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-patch-failure.html View 4 chunks +5 lines, -5 lines 0 comments Download
M milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-running.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-timeout.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-unicode.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-canceled.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-exception.html View 3 chunks +3 lines, -3 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-hang.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-patch-failure.html View 4 chunks +5 lines, -5 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-timeout.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-unicode.html View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/swarming/expectations/build-canceled.json View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/swarming/expectations/build-exception.json View 3 chunks +3 lines, -3 lines 0 comments Download
M milo/appengine/swarming/expectations/build-hang.json View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/swarming/expectations/build-patch-failure.json View 4 chunks +5 lines, -5 lines 0 comments Download
M milo/appengine/swarming/expectations/build-running.json View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/swarming/expectations/build-timeout.json View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/swarming/expectations/build-unicode.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Ryan Tseng
This is like the other CL, but does things in annotee instead of milo
4 years, 4 months ago (2016-08-22 20:32:05 UTC) #4
Ryan Tseng
Retrain
4 years, 4 months ago (2016-08-22 20:39:04 UTC) #7
dnj
lgtm
4 years, 4 months ago (2016-08-22 21:25:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268543003/20001
4 years, 4 months ago (2016-08-22 21:27:04 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:30:46 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/86950b2d9531c15386f2e5ccfc2a1a8aa1235464

Powered by Google App Engine
This is Rietveld 408576698