Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: logdog/client/annotee/annotation/annotation.go

Issue 2268543003: Annotee: Shorten logdog log link label (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Retrain Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | logdog/client/annotee/annotation/test_expectations/coverage_steps.proto.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/annotee/annotation/annotation.go
diff --git a/logdog/client/annotee/annotation/annotation.go b/logdog/client/annotee/annotation/annotation.go
index e5c8ddeaf86831963b69aaf69851932fc9173788..200b873912e11b763980e88458ed5f52b941afbe 100644
--- a/logdog/client/annotee/annotation/annotation.go
+++ b/logdog/client/annotee/annotation/annotation.go
@@ -753,7 +753,7 @@ func (as *Step) LogLine(label, line string) bool {
panic(fmt.Errorf("failed to generate log stream name for [%s]: %s", label, err))
}
name = as.BaseStream(subName)
- as.AddLogdogStreamLink("", "", name)
+ as.AddLogdogStreamLink("", label, "", name)
as.logLines[label] = name
as.logLineCount[label]++
@@ -847,8 +847,9 @@ func (as *Step) SetNestLevel(l int) bool {
}
// AddLogdogStreamLink adds a LogDog stream link to this Step's links list.
-func (as *Step) AddLogdogStreamLink(server string, prefix, name types.StreamName) {
+func (as *Step) AddLogdogStreamLink(server, label string, prefix, name types.StreamName) {
link := &milo.Link{
+ Label: label,
Value: &milo.Link_LogdogStream{&milo.LogdogStream{
Name: string(name),
Server: server,
« no previous file with comments | « no previous file | logdog/client/annotee/annotation/test_expectations/coverage_steps.proto.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698