[parser] Clean up (pre)parser traits, part 3

[parser] Clean up (pre)parser traits, part 3

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- BuildIteratorResult
- BuildUnaryExpression
- EmptyExpression
- EmptyFunctionLiteral
- EmptyIdentifier
- EmptyIdentifierString
- EmptyLiteral
- EmptyObjectLiteralProperty
- GetLiteralTheHole
- NewThrowReferenceError
- NewThrowSyntaxError
- NewThrowTypeError
- NullExpressionList
- ReportMessageAt

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/c374d4136ca3eed3bfc1bb042c0a409fa95afe6c
Cr-Commit-Position: refs/heads/master@{#38862}

[nickie, 2016-08-23 16:41:09]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 16:41:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 17:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 17:04:03]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-23 17:59:20]

lgtm

[marja, 2016-08-24 08:57:27]

https://codereview.chromium.org/2268413002/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2268413002/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:902: V8_INLINE Expression* NewThrowReferenceError(
Why did you put the implementation in the parser.h? Would it be ok to put it to
parser.cc... this forces parser.h to include stuff like Runtime, which we would
like to avoid (i.e., get rid of). Any particular reason to have the
implementations here? Is it needed because of the templateness of this all?

[marja, 2016-08-24 09:14:04]

lgtm

Offline discussion:

parser.h already needs to include runtime.h to get some constants, and it also
uses ast-value-factory.h which it doesn't directly include (but gets via
scopes.h), so this CL is not making the situation (much) worse. These funcs just
maybe have to move back to the .cc after #includes are less tangled.

[nickie, 2016-08-24 09:16:31]

https://codereview.chromium.org/2268413002/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2268413002/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:902: V8_INLINE Expression* NewThrowReferenceError(
On 2016/08/24 08:57:27, marja wrote:
> Why did you put the implementation in the parser.h? Would it be ok to put it
to
> parser.cc... this forces parser.h to include stuff like Runtime, which we
would
> like to avoid (i.e., get rid of). Any particular reason to have the
> implementations here? Is it needed because of the templateness of this all?

We discussed this offline.  No, it doesn't have anything to do with templates. 
My rationale was that methods with small and relatively simple implementations
would rather be inlined, for performance.  If later on we want to clean up
header files and decide that sacrificing inlining is a good tradeoff, we can
take methods like this back to the .cc files.

[nickie, 2016-08-24 10:20:10]

The CQ bit was checked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-08-24 10:20:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 10:22:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-24 10:22:50]

Description was changed from

==========
[parser] Clean up (pre)parser traits, part 3

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- BuildIteratorResult
- BuildUnaryExpression
- EmptyExpression
- EmptyFunctionLiteral
- EmptyIdentifier
- EmptyIdentifierString
- EmptyLiteral
- EmptyObjectLiteralProperty
- GetLiteralTheHole
- NewThrowReferenceError
- NewThrowSyntaxError
- NewThrowTypeError
- NullExpressionList
- ReportMessageAt

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Clean up (pre)parser traits, part 3

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- BuildIteratorResult
- BuildUnaryExpression
- EmptyExpression
- EmptyFunctionLiteral
- EmptyIdentifier
- EmptyIdentifierString
- EmptyLiteral
- EmptyObjectLiteralProperty
- GetLiteralTheHole
- NewThrowReferenceError
- NewThrowSyntaxError
- NewThrowTypeError
- NullExpressionList
- ReportMessageAt

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/c374d4136ca3eed3bfc1bb042c0a409fa95afe6c
Cr-Commit-Position: refs/heads/master@{#38862}
==========

[commit-bot: I haz the power, 2016-08-24 10:22:53]

Patchset 1 (id:??) landed as
https://crrev.com/c374d4136ca3eed3bfc1bb042c0a409fa95afe6c
Cr-Commit-Position: refs/heads/master@{#38862}