[parser] Clean up (pre)parser traits, part 2

[parser] Clean up (pre)parser traits, part 2

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- AsIdentifier
- CheckAssigningFunctionLiteralToProperty
- GetPropertyValue
- InferFunctionName
- IsArguments
- IsArrayIndex
- IsBoilerplateProperty
- IsConstructor
- IsDirectEvalCall
- IsEval
- IsEvalOrArguments
- IsFutureStrictReserved
- IsIdentifier
- IsPrototype
- IsThisProperty
- IsUndefined
- MarkExpressionAsAssigned
- PushLiteralName
- PushPropertyName
- ShortcutNumericLiteralBinaryExpression

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/626309272ec4b08a5656f86950686e80bcf45170
Cr-Commit-Position: refs/heads/master@{#38861}

[adamk, 2016-08-23 16:03:45]

lgtm

https://codereview.chromium.org/2273693002/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2273693002/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:827: // Helper functions for recursive descent.
I don't think this comment carries its weight

[marja, 2016-08-24 08:50:00]

rubberstamp-y lgtm, as in, didn't check each line of code separately, trusting
that you moved it around correctly :)

[nickie, 2016-08-24 09:05:24]

The CQ bit was checked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-08-24 09:05:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 09:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 09:06:38]

Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/11495)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7550)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22455)

[nickie, 2016-08-24 09:45:56]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-08-24 09:45:56]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2273693002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-24 09:46:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 10:08:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 10:08:53]

Description was changed from

==========
[parser] Clean up (pre)parser traits, part 2

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- AsIdentifier
- CheckAssigningFunctionLiteralToProperty
- GetPropertyValue
- InferFunctionName
- IsArguments
- IsArrayIndex
- IsBoilerplateProperty
- IsConstructor
- IsDirectEvalCall
- IsEval
- IsEvalOrArguments
- IsFutureStrictReserved
- IsIdentifier
- IsPrototype
- IsThisProperty
- IsUndefined
- MarkExpressionAsAssigned
- PushLiteralName
- PushPropertyName
- ShortcutNumericLiteralBinaryExpression

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Clean up (pre)parser traits, part 2

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- AsIdentifier
- CheckAssigningFunctionLiteralToProperty
- GetPropertyValue
- InferFunctionName
- IsArguments
- IsArrayIndex
- IsBoilerplateProperty
- IsConstructor
- IsDirectEvalCall
- IsEval
- IsEvalOrArguments
- IsFutureStrictReserved
- IsIdentifier
- IsPrototype
- IsThisProperty
- IsUndefined
- MarkExpressionAsAssigned
- PushLiteralName
- PushPropertyName
- ShortcutNumericLiteralBinaryExpression

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/626309272ec4b08a5656f86950686e80bcf45170
Cr-Commit-Position: refs/heads/master@{#38861}
==========

[commit-bot: I haz the power, 2016-08-24 10:08:54]

Patchset 2 (id:??) landed as
https://crrev.com/626309272ec4b08a5656f86950686e80bcf45170
Cr-Commit-Position: refs/heads/master@{#38861}