Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2268383002: [css-grid] Avoid negative values as override containing block sizes (Closed)

Created:
4 years, 4 months ago by Manuel Rego
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, Manuel Rego, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, svillar, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Avoid negative values as override containing block sizes Add DCHECK to verify that we don't set negative values (other than -1 which means indefinite) as override containing block sizes. Modified LayoutGrid::offsetAndBreadthForPositionedChild() to never return negative breadths. BUG=639620 Committed: https://crrev.com/83e4af423ad2b700659ef45ea0790ae2f8fd30ea Cr-Commit-Position: refs/heads/master@{#413791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
4 years, 4 months ago (2016-08-23 15:09:08 UTC) #2
cbiesinger
lgtm
4 years, 4 months ago (2016-08-23 15:32:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268383002/1
4 years, 4 months ago (2016-08-23 15:40:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 18:25:46 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 18:27:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83e4af423ad2b700659ef45ea0790ae2f8fd30ea
Cr-Commit-Position: refs/heads/master@{#413791}

Powered by Google App Engine
This is Rietveld 408576698