Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2268383002: [css-grid] Avoid negative values as override containing block sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 3d31f030e6dc222eeb9b4d20ea93253952863ffa..3ac149226ea287ae482c741872f4534cd0e74266 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -1161,6 +1161,7 @@ bool LayoutBox::hasOverrideContainingBlockLogicalHeight() const
// TODO (lajava) Shouldn't we implement these functions based on physical direction ?.
void LayoutBox::setOverrideContainingBlockContentLogicalWidth(LayoutUnit logicalWidth)
{
+ DCHECK_GE(logicalWidth, LayoutUnit(-1));
ensureRareData().m_overrideContainingBlockContentLogicalWidth = logicalWidth;
ensureRareData().m_hasOverrideContainingBlockContentLogicalWidth = true;
}
@@ -1168,6 +1169,7 @@ void LayoutBox::setOverrideContainingBlockContentLogicalWidth(LayoutUnit logical
// TODO (lajava) Shouldn't we implement these functions based on physical direction ?.
void LayoutBox::setOverrideContainingBlockContentLogicalHeight(LayoutUnit logicalHeight)
{
+ DCHECK_GE(logicalHeight, LayoutUnit(-1));
ensureRareData().m_overrideContainingBlockContentLogicalHeight = logicalHeight;
ensureRareData().m_hasOverrideContainingBlockContentLogicalHeight = true;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698