Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2268373002: clean up media tests (Closed)

Created:
4 years, 4 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
fs, blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clean up media tests Removed unnecessary markup (<div id="log">). Removed unnecessary "controls" attribute. Use step_func_done whereever possible. Committed: https://crrev.com/5b77d4bc4df036650097cf395f8be17b04f62c6e Cr-Commit-Position: refs/heads/master@{#413754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -153 lines) Patch
M third_party/WebKit/LayoutTests/media/adopt-node-video-controls-crash.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/audio-controls-computed-display.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/autoplay.html View 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/autoplay-clears-autoplaying-flag.html View 1 chunk +8 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/autoplay-with-preload-none.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/avtrack/addtrack.html View 2 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/avtrack/audio-track-enabled.html View 1 chunk +13 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html View 1 chunk +9 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/avtrack/forget-on-load.html View 1 chunk +10 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/avtrack/gc.html View 1 chunk +11 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/avtrack/getTrackById.html View 1 chunk +13 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/avtrack/video-track-properties.html View 1 chunk +9 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/avtrack/video-track-selected.html View 1 chunk +16 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/effective-media-volume.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-controls-fit-properly-while-zoomed.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-controls-play-button-visible.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/text-track-cue-constructor.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-element-load-event.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-remove-track.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-fullscreen.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-fullscreen-iframe-allowed.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-fullscreen-iframe-not-allowed.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-fullscreen-not-supported.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-intrinsic-width-height.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-playing-and-pause.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-positive-start-time.html View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-positive-start-time-seek-after-start-time.html View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-positive-start-time-seek-before-start-time.html View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Srirama
PTAL
4 years, 4 months ago (2016-08-23 14:02:55 UTC) #3
fs
lgtm
4 years, 4 months ago (2016-08-23 14:29:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268373002/1
4 years, 4 months ago (2016-08-23 14:54:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 16:21:13 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 16:22:42 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5b77d4bc4df036650097cf395f8be17b04f62c6e
Cr-Commit-Position: refs/heads/master@{#413754}

Powered by Google App Engine
This is Rietveld 408576698