third_party/WebKit/LayoutTests/media/avtrack/addtrack.html - Issue 2268373002: clean up media tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/avtrack/addtrack.html

Issue 2268373002: clean up media tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/autoplay-with-preload-none.html ('k') | third_party/WebKit/LayoutTests/media/avtrack/audio-track-enabled.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/avtrack/addtrack.html

diff --git a/third_party/WebKit/LayoutTests/media/avtrack/addtrack.html b/third_party/WebKit/LayoutTests/media/avtrack/addtrack.html

index 18c9097a42aeaffe411185562585840e8ac8ff5c..f8e8e07827c4d38d14bf162bfb7f571a40ceaa7b 100644

--- a/third_party/WebKit/LayoutTests/media/avtrack/addtrack.html

+++ b/third_party/WebKit/LayoutTests/media/avtrack/addtrack.html

@@ -7,7 +7,6 @@

</head>

<body>

- <div id="log"></div>

function addtrack_test(tagName, src, label)

{

@@ -29,30 +28,28 @@

async_test(function(t)

{

- var e = document.createElement(tagName);

- e.src = src;

+ var media = document.createElement(tagName);

+ media.src = src;

var expectedEvents = ["addtrack"];

var actualAudioEvents = [];

var actualVideoEvents = [];

- setupTrackListHandlers(t, e.audioTracks, actualAudioEvents, "audioTracks events");

- setupTrackListHandlers(t, e.videoTracks, actualVideoEvents, "videoTracks events");

+ setupTrackListHandlers(t, media.audioTracks, actualAudioEvents, "audioTracks events");

+ setupTrackListHandlers(t, media.videoTracks, actualVideoEvents, "videoTracks events");

- e.load();

+ media.load();

- e.addEventListener("loadedmetadata", t.step_func(function()

+ media.addEventListener("loadedmetadata", t.step_func_done(function()

{

assert_array_equals(actualAudioEvents, expectedEvents);

- if (e.videoTracks.length > 0) {

+ if (media.videoTracks.length > 0) {

assert_equals(label, "audio-video");

assert_array_equals(actualVideoEvents, expectedEvents);

} else {

assert_equals(label, "audio-only");

assert_equals(actualVideoEvents.length, 0);

}

- t.done();

}));

}, tagName + " : " + label);

}