Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2268183004: Fix git cl upload invocation in deps_updater.py. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix git cl upload invocation in deps_updater.py. This is a follow-up fix to http://crrev.com/2265603003. In this CL: - Add missing comma in arg list for git cl upload. This is causing recent builds to fail because "--rietveld" and "-m" are concatenated together, e.g. https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/6540 - Remove now-unused argument auth_refresh_token_json of do_auto_update. BUG=629275 Committed: https://crrev.com/c0ec8559a02e430a346d991b8e75d35eeb7088fa Cr-Commit-Position: refs/heads/master@{#414097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
4 years, 4 months ago (2016-08-23 23:04:17 UTC) #2
wkorman
lgtm
4 years, 4 months ago (2016-08-23 23:32:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268183004/1
4 years, 4 months ago (2016-08-24 16:15:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 17:24:56 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 17:26:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0ec8559a02e430a346d991b8e75d35eeb7088fa
Cr-Commit-Position: refs/heads/master@{#414097}

Powered by Google App Engine
This is Rietveld 408576698