Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2268183004: Fix git cl upload invocation in deps_updater.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
index c06ae5e7697803daab9a6223dcbb305d4de29bf2..3a84953c899e694e0f2574fdb873a2a88379cd16 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
@@ -59,7 +59,7 @@ class DepsUpdater(object):
has_changes = self.commit_changes_if_needed(chromium_commitish, import_commitish)
if options.auto_update and has_changes:
- commit_successful = self.do_auto_update(options.auth_refresh_token_json)
+ commit_successful = self.do_auto_update()
if not commit_successful:
return 1
return 0
@@ -260,7 +260,7 @@ class DepsUpdater(object):
def print_(self, msg):
self.host.print_(msg)
- def do_auto_update(self, auth_refresh_token_json):
+ def do_auto_update(self):
"""Attempts to upload a CL, make any required adjustments, and commit.
This function assumes that the imported repo has already been updated,
@@ -274,7 +274,7 @@ class DepsUpdater(object):
self.print_('## Uploading change list.')
cc_list = self.get_directory_owners_to_cc()
self.git_cl.run([
- 'upload', '-f', '--rietveld'
+ 'upload', '-f', '--rietveld',
'-m', 'W3C auto test import CL.\n\nTBR=qyearsley@chromium.org',
] + ['--cc=' + email for email in cc_list])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698