Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2268173005: Merge ExpressionClassifier::ObjectLiteralProduction into ExpressionProduction (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Merge ExpressionClassifier::ObjectLiteralProduction into ExpressionProduction They are both accumulated at the same time, and either one already triggered an error in ValidateExpression. Basically, there were no disjoint uses of these two error types. Committed: https://crrev.com/26fbac4b37ea504e508832bfea2156d2c4792833 Cr-Commit-Position: refs/heads/master@{#38922}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -33 lines) Patch
M src/parsing/expression-classifier.h View 1 3 chunks +2 lines, -19 lines 0 comments Download
M src/parsing/parser-base.h View 1 4 chunks +5 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
adamk
4 years, 4 months ago (2016-08-24 20:46:43 UTC) #4
gsathya
lgtm
4 years, 4 months ago (2016-08-24 21:49:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268173005/20001
4 years, 3 months ago (2016-08-25 23:06:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 00:02:48 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 00:03:03 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26fbac4b37ea504e508832bfea2156d2c4792833
Cr-Commit-Position: refs/heads/master@{#38922}

Powered by Google App Engine
This is Rietveld 408576698