Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: src/parsing/expression-classifier.h

Issue 2268173005: Merge ExpressionClassifier::ObjectLiteralProduction into ExpressionProduction (Closed)
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parsing/parser-base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/expression-classifier.h
diff --git a/src/parsing/expression-classifier.h b/src/parsing/expression-classifier.h
index 87b3bbe50ae694273da5bbdfa685abe7db78b5ef..b682816ebe9e761ef8358e658b7033ed94f26aef 100644
--- a/src/parsing/expression-classifier.h
+++ b/src/parsing/expression-classifier.h
@@ -23,9 +23,8 @@ class DuplicateFinder;
T(StrictModeFormalParametersProduction, 5) \
T(ArrowFormalParametersProduction, 6) \
T(LetPatternProduction, 7) \
- T(ObjectLiteralProduction, 8) \
- T(TailCallExpressionProduction, 9) \
- T(AsyncArrowFormalParametersProduction, 10)
+ T(TailCallExpressionProduction, 8) \
+ T(AsyncArrowFormalParametersProduction, 9)
template <typename Traits>
class ExpressionClassifier {
@@ -165,14 +164,6 @@ class ExpressionClassifier {
return reported_error(kLetPatternProduction);
}
- V8_INLINE bool has_object_literal_error() const {
- return !is_valid(ObjectLiteralProduction);
- }
-
- V8_INLINE const Error& object_literal_error() const {
- return reported_error(kObjectLiteralProduction);
- }
-
V8_INLINE bool has_tail_call_expression() const {
return !is_valid(TailCallExpressionProduction);
}
@@ -281,14 +272,6 @@ class ExpressionClassifier {
Add(Error(loc, message, kLetPatternProduction, arg));
}
- void RecordObjectLiteralError(const Scanner::Location& loc,
- MessageTemplate::Template message,
- const char* arg = nullptr) {
- if (has_object_literal_error()) return;
- invalid_productions_ |= ObjectLiteralProduction;
- Add(Error(loc, message, kObjectLiteralProduction, arg));
- }
-
void RecordTailCallExpressionError(const Scanner::Location& loc,
MessageTemplate::Template message,
const char* arg = nullptr) {
« no previous file with comments | « no previous file | src/parsing/parser-base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698