gpu host: Delete GpuMsg_Finalize

gpu host: Delete GpuMsg_Finalize

This appears to be dead code.

BUG=none

[Fady Samuel, 2016-08-22 15:48:04]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 15:48:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-08-22 15:49:02]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org, sadrul@chromium.org

[Fady Samuel, 2016-08-22 15:49:03]

+sadrul@: FYI
+piman@: OWNERS

[commit-bot: I haz the power, 2016-08-22 17:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 17:38:45]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-22 18:47:00]

Yay killing dead code! lgtm

[piman, 2016-08-22 19:35:29]

piman@chromium.org changed reviewers:
+ derekjchow@chromium.org

[piman, 2016-08-22 19:35:29]

+derekjchow who initially introduced this, in
https://codereview.chromium.org/1249313004

I believe this is used for ChromeCast, but maybe the calling code is not in
tree? Is this still used?

[derekjchow1, 2016-08-22 20:19:05]

+halliwell

Correct, we're still using StopGpuProcess (and GpuMsg_Finalize) internally in
the chromecast tree.

[derekjchow1, 2016-08-22 20:19:18]

derekjchow@chromium.org changed reviewers:
+ halliwell@chromium.org

[halliwell, 2016-08-22 20:26:17]

On 2016/08/22 20:19:18, derekjchow1 wrote:

Correct, we need this.

We should definitely move the calling code upstream and add tests.

[piman, 2016-08-22 20:33:15]

On Mon, Aug 22, 2016 at 1:26 PM, <halliwell@chromium.org> wrote:

> On 2016/08/22 20:19:18, derekjchow1 wrote:
>
> Correct, we need this.
>
> We should definitely move the calling code upstream and add tests.
>

That would be very much appreciated!


>
> https://codereview.chromium.org/2267843002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Fady Samuel, 2016-08-22 20:34:38]

On 2016/08/22 20:33:15, piman wrote:
> On Mon, Aug 22, 2016 at 1:26 PM, <mailto:halliwell@chromium.org> wrote:
> 
> > On 2016/08/22 20:19:18, derekjchow1 wrote:
> >
> > Correct, we need this.
> >
> > We should definitely move the calling code upstream and add tests.
> >
> 
> That would be very much appreciated!
> 
> 
> >
> > https://codereview.chromium.org/2267843002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

OK. I'm closing this! Thanks all! :-)

[Fady Samuel, 2016-08-22 20:34:49]

Description was changed from

==========
gpu host: Delete GpuMsg_Finalize

This appears to be dead code.

BUG=none
==========

to

==========
gpu host: Delete GpuMsg_Finalize

This appears to be dead code.

BUG=none
==========

[halliwell, 2016-08-22 20:36:27]

On 2016/08/22 20:34:38, Fady Samuel wrote:
> On 2016/08/22 20:33:15, piman wrote:
> > On Mon, Aug 22, 2016 at 1:26 PM, <mailto:halliwell@chromium.org> wrote:
> > 
> > > On 2016/08/22 20:19:18, derekjchow1 wrote:
> > >
> > > Correct, we need this.
> > >
> > > We should definitely move the calling code upstream and add tests.
> > >
> > 
> > That would be very much appreciated!
> > 
> > 
> > >
> > > https://codereview.chromium.org/2267843002/
> > >
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> OK. I'm closing this! Thanks all! :-)

Sorry for the wasted time Fady.  I filed crbug/639941 for us to follow up on
this.