clang plugin: Remove check-templates toggle.

tools/clang/plugins/FindBadConstructsConsumer.cpp

Index: tools/clang/plugins/FindBadConstructsConsumer.cpp
diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp
index 0cb0a08820437fa3ca8cb68a59f892e681f107c6..8cbb94f6a00efb902cdb69ff9a9677ac8953f292 100644
--- a/tools/clang/plugins/FindBadConstructsConsumer.cpp
+++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp
@@ -221,7 +221,7 @@ void FindBadConstructsConsumer::CheckChromeClass(SourceLocation record_location,
   // That was only a mistake; once Chromium code passes these checks, we should
   // remove the "check-templates" option and remove this code.
   // See crbug.com/441916
-  if (!options_.check_templates && IsPodOrTemplateType(*record))

[hans, 2016/08/24 23:33:19]

Wait, if options_.check_templates is always true, doesn't that mean we should
never return here, i.e. the whole if-statement (and comment above) should be
killed?

+  if (IsPodOrTemplateType(*record))
     return;
 
   bool implementation_file = InImplementationFile(record_location);