Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2267663003: [system-health] Actually enable browser logging in smoke test (Closed)

Created:
4 years, 4 months ago by petrcermak
Modified:
4 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system-health] Actually enable browser logging in smoke test It turns out that the original patch (https://codereview.chromium.org/2133093002) didn't actually enable browser logging in the System Health smoke tests. BUG=623058, 639538 Committed: https://crrev.com/3d44ebe6c88dbce694e2cdce41c5bd12246ce1e4 Cr-Commit-Position: refs/heads/master@{#413437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 4 months ago (2016-08-22 12:13:16 UTC) #2
nednguyen
lgtm
4 years, 4 months ago (2016-08-22 12:45:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267663003/1
4 years, 4 months ago (2016-08-22 12:45:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 13:41:30 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 13:43:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d44ebe6c88dbce694e2cdce41c5bd12246ce1e4
Cr-Commit-Position: refs/heads/master@{#413437}

Powered by Google App Engine
This is Rietveld 408576698