tools/perf/benchmarks/system_health_smoke_test.py - Issue 2267663003: [system-health] Actually enable browser logging in smoke test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2267663003: [system-health] Actually enable browser logging in smoke test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/system_health_smoke_test.py

diff --git a/tools/perf/benchmarks/system_health_smoke_test.py b/tools/perf/benchmarks/system_health_smoke_test.py

index d08f971f0ddfa777b75bee808f3353275df9bdaa..75d35ac6f0644f41a356c510b20945b17c0566cf 100644

--- a/tools/perf/benchmarks/system_health_smoke_test.py

+++ b/tools/perf/benchmarks/system_health_smoke_test.py

@@ -109,7 +109,7 @@ def GenerateBenchmarkOptions(benchmark_class):

# Enable browser logging in the smoke test only. Hopefully, this will detect

# all crashes and hence remove the need to enable logging in actual perf

# benchmarks.

- options.logging_verbosity = 'non-verbose'

+ options.browser_options.logging_verbosity = 'non-verbose'

return options

« no previous file with comments | « no previous file | no next file » | no next file with comments »