[wasm] asm.js - Check stdlib functions are valid.

[wasm] asm.js - Check stdlib functions are valid.

Check remaining asm.js stdlib functions for validitity at instatiation.

Fail when a member is referenced, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org

Committed: https://crrev.com/2d46ef23b192d7492c2c56799473aee3d948bba6
Cr-Commit-Position: refs/heads/master@{#38796}

[bradnelson, 2016-08-22 04:44:18]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 04:44:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 05:05:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 05:05:14]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-08-22 05:10:41]

PTAL

[titzer, 2016-08-22 08:41:22]

lgtm with comment

https://codereview.chromium.org/2267633002/diff/1/src/asmjs/asm-js.cc
File src/asmjs/asm-js.cc (right):

https://codereview.chromium.org/2267633002/diff/1/src/asmjs/asm-js.cc#newcode102
src/asmjs/asm-js.cc:102: #define STDLIB_MATH_FUNC(CamelName, fname)             
                       \
That's a pretty big macro. Can you factor some of it out into a helper function?

[bradnelson, 2016-08-22 16:53:36]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[bradn, 2016-08-22 16:53:40]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-08-22 16:53:40]

https://codereview.chromium.org/2267633002/diff/1/src/asmjs/asm-js.cc
File src/asmjs/asm-js.cc (right):

https://codereview.chromium.org/2267633002/diff/1/src/asmjs/asm-js.cc#newcode102
src/asmjs/asm-js.cc:102: #define STDLIB_MATH_FUNC(CamelName, fname)             
                       \
On 2016/08/22 08:41:22, titzer wrote:
> That's a pretty big macro. Can you factor some of it out into a helper
function?

Good idea.
Done.

[commit-bot: I haz the power, 2016-08-22 16:53:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2016-08-22 16:59:07]

Description was changed from

==========
[wasm] asm.js - Check stdlib functions are valid.

Check remaining asm.js stdlib functions for validitity at instatiation.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Check stdlib functions are valid.

Check remaining asm.js stdlib functions for validitity at instatiation.

Fail when a member is referenced, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[bradn, 2016-08-22 17:01:16]

The CQ bit was unchecked by bradnelson@google.com

[bradn, 2016-08-22 17:01:17]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-08-22 17:01:17]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2267633002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-08-22 17:01:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 17:17:40]

Description was changed from

==========
[wasm] asm.js - Check stdlib functions are valid.

Check remaining asm.js stdlib functions for validitity at instatiation.

Fail when a member is referenced, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Check stdlib functions are valid.

Check remaining asm.js stdlib functions for validitity at instatiation.

Fail when a member is referenced, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[commit-bot: I haz the power, 2016-08-22 17:17:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 17:18:05]

Description was changed from

==========
[wasm] asm.js - Check stdlib functions are valid.

Check remaining asm.js stdlib functions for validitity at instatiation.

Fail when a member is referenced, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Check stdlib functions are valid.

Check remaining asm.js stdlib functions for validitity at instatiation.

Fail when a member is referenced, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org

Committed: https://crrev.com/2d46ef23b192d7492c2c56799473aee3d948bba6
Cr-Commit-Position: refs/heads/master@{#38796}
==========

[commit-bot: I haz the power, 2016-08-22 17:18:07]

Patchset 2 (id:??) landed as
https://crrev.com/2d46ef23b192d7492c2c56799473aee3d948bba6
Cr-Commit-Position: refs/heads/master@{#38796}