third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index d7c0f26d43f625e1156c65fc56020f0ab9cebb26..82839c52e27b4140555b5fb4fadce1c236142166 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -118,7 +118,6 @@ void V8Window::frameElementAttributeGetterCustom(const v8::PropertyCallbackInfo<

// The wrapper for an <iframe> should get its prototype from the context of the frame it's in, rather than its own frame.

// So, use its containing document as the creation context when wrapping.

v8::Local<v8::Value> creationContext = toV8(&impl->frameElement()->document(), info.Holder(), info.GetIsolate());

- RELEASE_ASSERT(!creationContext.IsEmpty());

v8::Local<v8::Value> wrapper = toV8(impl->frameElement(), v8::Local<v8::Object>::Cast(creationContext), info.GetIsolate());

v8SetReturnValue(info, wrapper);

}