third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp - Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

index d17b5d1208b5f139e0aefc59eedf86135402a375..0f8ffbb1b4f19a7b4e62a977722b92189e44bb24 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

@@ -82,8 +82,6 @@ void V8PopStateEvent::stateAttributeGetterCustom(const v8::FunctionCallbackInfo<

if (isSameState) {

v8::Local<v8::Value> v8HistoryValue = toV8(history, info.Holder(), info.GetIsolate());

- if (v8HistoryValue.IsEmpty())

- return;

v8::Local<v8::Object> v8History = v8HistoryValue.As<v8::Object>();

if (!history->stateChanged()) {

result = V8HiddenValue::getHiddenValue(scriptState, v8History, V8HiddenValue::state(info.GetIsolate()));