third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp - Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

index 8689282361e7631e7c69343cf1a44397a6668b80..cc73b9374a72f407f4cdfafbe15f4b3aba035a6e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

@@ -69,8 +69,6 @@ v8::Local<v8::Object> toObjectWrapper(T* domObject, ScriptState* scriptState)

if (!domObject)

return v8::Object::New(scriptState->isolate());

v8::Local<v8::Value> value = toV8(domObject, scriptState->context()->Global(), scriptState->isolate());

- if (value.IsEmpty())

- return v8::Object::New(scriptState->isolate());

return v8::Local<v8::Object>::New(scriptState->isolate(), value.As<v8::Object>());

}