third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp - Issue 2267403006: Remove redundant IsEmpty checks after calling toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

Issue 2267403006: Remove redundant IsEmpty checks after calling toV8() Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp b/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

index fac9b6d9e08227bb9ea4ecd2b6ce2ef3f88a3028..1ae21b7c5eb52184538c8e8036e120bafaae8dd6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

@@ -43,9 +43,6 @@ void V8IntersectionObserverCallback::handleEvent(const HeapVector<Member<Interse

v8::Local<v8::Object> thisObject = v8::Local<v8::Object>::Cast(observerHandle);

v8::Local<v8::Value> entriesHandle = toV8(entries, m_scriptState->context()->Global(), m_scriptState->isolate());

- if (entriesHandle.IsEmpty()) {

- return;

- }

v8::Local<v8::Value> argv[] = { entriesHandle, observerHandle };

v8::TryCatch exceptionCatcher(m_scriptState->isolate());