GN: more optional components: jpeg, pdf, png, xml

GN: more optional components: jpeg, pdf, png, xml

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267343004

Committed: https://skia.googlesource.com/skia/+/6321381d18f9d478598c0996c1380633003961dd

[mtklein_C, 2016-08-24 15:59:44]

Description was changed from

==========
GN: more optional components: jpeg, pdf, png, xml

BUG=skia:
==========

to

==========
GN: more optional components: jpeg, pdf, png, xml

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267343004
==========

[mtklein_C, 2016-08-24 16:00:44]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:00:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 16:05:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:05:13]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[mtklein_C, 2016-08-24 16:09:38]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:09:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 16:12:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:12:53]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[mtklein_C, 2016-08-24 16:25:33]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-24 16:34:17]

mtklein@chromium.org changed reviewers:
+ halcanary@google.com, jcgregorio@google.com, msarett@google.com

[mtklein_C, 2016-08-24 16:34:18]

Please take a look at the parts you are familiar with.

[jcgregorio, 2016-08-24 16:38:01]

lgtm

[msarett, 2016-08-24 16:38:15]

codec lgtm

[commit-bot: I haz the power, 2016-08-24 16:41:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:41:51]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-08-24 16:41:51]

https://codereview.chromium.org/2267343004/diff/40001/src/codec/SkPngCodec.h
File src/codec/SkPngCodec.h (right):

https://codereview.chromium.org/2267343004/diff/40001/src/codec/SkPngCodec.h#...
src/codec/SkPngCodec.h:17: // Instead of including png.h here, forward declare
the few types we refer to.
This should work.  I believe we've had issues in the past because old versions
of libpng used different names for these structs.

We are working towards requiring 1.6 now.

Might want to use CMake trybots though.

[mtklein_C, 2016-08-24 16:54:18]

> Might want to use CMake trybots though.

All passing.

[hal.canary, 2016-08-24 16:54:47]

skia_use_sfntly: LGTM
src/pdf: LGTM

[mtklein_C, 2016-08-24 16:54:53]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-08-24 16:55:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-24 16:55:29]

Thanks guys!

[commit-bot: I haz the power, 2016-08-24 16:55:58]

Description was changed from

==========
GN: more optional components: jpeg, pdf, png, xml

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267343004
==========

to

==========
GN: more optional components: jpeg, pdf, png, xml

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2267343004

Committed:
https://skia.googlesource.com/skia/+/6321381d18f9d478598c0996c1380633003961dd
==========

[commit-bot: I haz the power, 2016-08-24 16:55:59]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6321381d18f9d478598c0996c1380633003961dd