Issue 226733003: Fix record_wpr. Currently, it only runs actions inside RunNavigateSteps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226733003: Fix record_wpr. Currently, it only runs actions inside RunNavigateSteps (Closed)

Created:
6 years, 8 months ago by nednguyen

Modified:
6 years, 8 months ago

Reviewers:
tonyg, dtu, nduca

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Fix bug in record_wpr. Currently, it only runs actions inside RunNavigateSteps BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261969

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -1 line)			Patch
	M	tools/telemetry/telemetry/page/record_wpr.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	tools/telemetry/telemetry/page/record_wpr_unittest.py	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

nednguyen

I discover this bug when moving some of our page_sets to python.

6 years, 8 months ago (2014-04-04 22:48:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/226733003/20001

6 years, 8 months ago (2014-04-04 23:17:56 UTC) #4

Message was sent while issue was closed.

Change committed as 261969