tools/telemetry/telemetry/page/record_wpr.py - Issue 226733003: Fix record_wpr. Currently, it only runs actions inside RunNavigateSteps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 226733003: Fix record_wpr. Currently, it only runs actions inside RunNavigateSteps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unittest coverage Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/record_wpr.py

diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py

index c1cfdae8fe81d7eaac55ea2a26833bfaaabfeaa5..ace54e24d6aea7eca42489125d126c040059c691 100755

--- a/tools/telemetry/telemetry/page/record_wpr.py

+++ b/tools/telemetry/telemetry/page/record_wpr.py

@@ -80,7 +80,7 @@ class RecordPage(page_test.PageTest):

if interactive:

action_runner.RunAction(interact.InteractAction())

else:

- self._RunMethod(page, self._action_name_to_run, action_runner)

+ self._RunMethod(page, action_name, action_runner)

should_reload = True

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/record_wpr_unittest.py » ('j') | no next file with comments »